Two trailing newlines in formatted file

[wdscxsj]

Hi, it seems there are always two trailing newline characters in a formatted .templ file, instead of one. Is that intentional? Thanks.

[a-h]

No, it's not intentional.

Likely just because of the simple iteration at

templ/parser/v2/types.go

Lines 103 to 120 in 6327fb4

	func (tf TemplateFile) Write(w io.Writer) error {
	var indent int
	if err := tf.Package.Write(w, indent); err != nil {
	return err
	}
	if _, err := w.Write([]byte("\n\n")); err != nil {
	return err
	}
	for i := 0; i < len(tf.Nodes); i++ {
	if err := tf.Nodes[i].Write(w, indent); err != nil {
	return err
	}
	if _, err := w.Write([]byte("\n\n")); err != nil {
	return err
	}
	}
	return nil
	}

Checking whether it's the last node in the file, and only outputting a single newline would likely fix it.

I'd take a PR for that!

[wdscxsj]

Thanks for the tip! PR proposed.

[wdscxsj]

By the way, in the KillAll() function of cmd/templ/generatecmd/run/run.go, is it better to use cmd.Process.Kill() instead of TASKKILL and syscall?

[a-h]

The reasoning for KillAll() is that if you run go run . or similar as your task, then go run will create a binary in the tmp directory, and run that binary. This creates a new process, with its own pid.

I originally thought that process.Kill() would kill the child processes, but apparently I didn't read the documentation properly. 😂

So... apparently, the solution is to do this syscall stuff, or use TASKKILL on Windows.

[wdscxsj]

Child processes, now I see. Thank you!

[a-h]

I think this one is closed...