Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.5.1 #201

Merged
merged 12 commits into from
Aug 1, 2022
Merged

V1.5.1 #201

merged 12 commits into from
Aug 1, 2022

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Jul 27, 2022

Reference Issues/PRs

#198 #199 #200

What does this implement/fix? Explain your changes

  • Adds missing MSE residue to constants
  • Fixes chain id check in atomic edge construction
  • Fixes incorrect deprotonation proceduce in protein graph construction

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2022

Codecov Report

Merging #201 (4d3684f) into master (8123f42) will increase coverage by 7.62%.
The diff coverage is 51.35%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   40.27%   47.89%   +7.62%     
==========================================
  Files          48       92      +44     
  Lines        2811     5502    +2691     
==========================================
+ Hits         1132     2635    +1503     
- Misses       1679     2867    +1188     
Impacted Files Coverage Δ
graphein/grn/parse_trrust.py 37.77% <ø> (ø)
graphein/ml/diffusion.py 0.00% <0.00%> (ø)
graphein/ppi/edges.py 100.00% <ø> (ø)
graphein/ppi/graph_metadata.py 0.00% <ø> (ø)
graphein/ppi/graphs.py 54.34% <ø> (ø)
graphein/ppi/parse_biogrid.py 75.00% <ø> (ø)
graphein/ppi/visualisation.py 0.00% <0.00%> (ø)
graphein/protein/analysis.py 0.00% <0.00%> (ø)
graphein/protein/edges/intramolecular.py 22.68% <0.00%> (ø)
graphein/protein/features/sequence/utils.py 28.00% <0.00%> (+3.00%) ⬆️
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner Author

@a-r-j a-r-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@a-r-j a-r-j merged commit c07fc78 into master Aug 1, 2022
@a-r-j a-r-j deleted the v1.5.1 branch November 10, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants