Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore tests #78

Closed
thedavidmeister opened this issue May 17, 2023 · 3 comments
Closed

Ability to ignore tests #78

thedavidmeister opened this issue May 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@thedavidmeister
Copy link

As per #15 and #30 there are certain features that halmos doesn't currently support.

Refactoring fuzz tests to a form that halmos supports is not always beneficial or possible, for example in #30 the suggestion was to avoid dynamic arrays and use fixed size arrays instead. In the code I was testing this would result in loss of generality of the space the fuzz tester is scanning from all possible length arrays to one or several examples of specific length arrays.

I'd like to be able to keep my more general fuzz test, that can go more places that halmos can, albeit with weaker guarantees, but then tell halmos to ignore those tests.

I could then use halmos to provide stronger proofs for the tests that it does support, which is better than not being able to use halmos at all (seems to be current state of things) if i fuzz something unsupported anywhere in my repo.

@thedavidmeister thedavidmeister added the enhancement New feature or request label May 17, 2023
@karmacoma-eth
Copy link
Collaborator

karmacoma-eth commented May 17, 2023

The way I would recommend doing this is by explicitly calling halmos with the function name prefix you want, e.g.:

  • halmos --function test: testXYZ would be executed/fuzzed by both forge and halmos
  • halmos --function check: checkXYZ would be executed by halmos only and ignored by forge

Does that work for you?

@thedavidmeister
Copy link
Author

@karmacoma-eth hmm, ok is that just a regex style matcher that halmos already has?

@karmacoma-eth
Copy link
Collaborator

@thedavidmeister yes, although at the moment it's prefix only (rather than full regex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants