-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone player #3
Comments
Definitely a good idea, though I'd need to introduce some sort of viewer callback mechanism from the player. Hmm. |
You could use https://github.com/nwjs or https://github.com/atom/electron for the standalone client. |
@luckcolors I meant a library that only cares about reproducing the file, without the visualisation part. |
Yeah. I'll work on splitting it out. The code needs a bunch of cleanup first, and a unit test suite before that, because it's sort of fragile, since so many mods rely on various corner cases. Trackers didn't have linters back then :/ |
@mrdoob Ah ok. I will make a separate issue for the native app. |
oops, bumped the button. A native app sort of defeats the purpose... |
Well it will be just packaged in a differen way. |
With 8e114a1 it's now possible to play without a viewer, though you still need to create a few XMView stubs to do it. I'll have to add a few checks so that isn't necessary. |
The code which defines what the buttons do and downloads songs and so
Loading trackview.js is now optional; without it, the player won't do
|
May I suggest... |
Heh, yeah, now that those functions moved into the namespace, that makes more sense... |
What do you think about taking the viewer code out of xm.js into viewer.js so xm.js can be used as standalone player? (You know, for demos and stuff 😉)
The text was updated successfully, but these errors were encountered: