Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 3 compatibility #344

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

sophie-mulard
Copy link
Contributor

Template allowing compatibility with bootstrap 3 and sonata admin

@sophie-mulard sophie-mulard mentioned this pull request Mar 30, 2020
@webda2l
Copy link
Member

webda2l commented Mar 30, 2020

From previous template compatible v3, https://github.com/a2lix/TranslationFormBundle/pull/307/files#diff-ab2e3216fab71c85bdff24a18bb04446, classes nav-item & nav-link could be removed to avoid pollute css maybe

@sophie-mulard
Copy link
Contributor Author

From previous template compatible v3, https://github.com/a2lix/TranslationFormBundle/pull/307/files#diff-ab2e3216fab71c85bdff24a18bb04446, classes nav-item & nav-link could be removed to avoid pollute css maybe

Indeed, we don't need these classes in bootstrap 3.
I removed them from both twigs

@webda2l webda2l merged commit 4a5f7c3 into a2lix:master Apr 3, 2020
@webda2l
Copy link
Member

webda2l commented Apr 3, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants