Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All window title bar text *appears* to have lopsided vertical alignment #744

Closed
xandark opened this issue Mar 5, 2023 · 3 comments
Closed
Labels
bug DeskTop DeskTop bugs or feature requests
Milestone

Comments

@xandark
Copy link

xandark commented Mar 5, 2023

This is not a "bug" per-se, but a visual issue that has niggled at me since I first began playing with A2D...

The title bar text of windows appear "too high" in their allotted space because there's 3 blank scan lines below the text and only 1 blank scan line above.

Yes, I realize that the 2px descenders of the system font make the font mathematically vertically aligned in the title bar space, but it doesn't appear vertically aligned. There is 98% more white space below the text than above:

Screenshot 2023-03-04 (18∶05∶09)

Am I the only one who thinks that the title bar text appears to float "too high" in the title bar? I actually prefer the way Catalyst looks in this regard.

What would it look like to have the text offset down 1px?

@xandark xandark added bug DeskTop DeskTop bugs or feature requests labels Mar 5, 2023
@inexorabletash
Copy link
Collaborator

image

I dunno... it looks a little awkward to me shifted down a pixel. Not a big surprise, the low vertical resolution of DHGR means lots of compromises.

For posterity:

diff --git a/mgtk/mgtk.s b/mgtk/mgtk.s
index b104858d..3ce98002 100644
--- a/mgtk/mgtk.s
+++ b/mgtk/mgtk.s
@@ -7207,6 +7207,7 @@ .proc DrawWindow
         jsr     FillAndFrameRect
         jsr     CenterTitleText
 
+        inc16   current_penloc_y
         ldax    current_winfo::title
         jsr     DrawText

@xandark
Copy link
Author

xandark commented Mar 6, 2023

Thanks for the visual test. That's interesting, so you're saying it looks awkward to you shifted down a pixel? To me it looks more visually faithful as an early Mac reproduction. The amount of negative space above and below the body of the title's text is now even and it feels balanced to my eyes.

I created some side-by-side comparisons based on your screenshot because you have several good titles there. Image on the left is the current A2D style and the right is the 1 pixel shift:

side by side

comparison split

To my eye, in the "Media" and "Vids" window titles, I can see a significant difference from just moving it down one scanline; the title text no longer seems to float high. My background is visual arts, so these details are important to me.

Other projects have dedicated graphic designers to work out GUI pixel stuff, but maybe we could put up a community poll and see what others think?

@inexorabletash
Copy link
Collaborator

Informal poll of users on the Slack shows a preference for the tweaked layout. So going with that for now.

@inexorabletash inexorabletash added this to the 1.3 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DeskTop DeskTop bugs or feature requests
Projects
None yet
Development

No branches or pull requests

2 participants