Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed Analyzer blocks replace_link_with_first_in_nav #8

Closed
patej opened this issue Oct 7, 2018 · 5 comments
Closed

Speed Analyzer blocks replace_link_with_first_in_nav #8

patej opened this issue Oct 7, 2018 · 5 comments

Comments

@patej
Copy link

patej commented Oct 7, 2018

This add-on seems to block the "replace_link_with_first_in_nav" attribute from working, at least on Concrete5 8.4.2. The redirection had suddenly stopped working, but after disabling Speed Analyzer it started to work again.

@a3020
Copy link
Owner

a3020 commented Oct 8, 2018

Thanks for reporting. I'd probably recommend enabling Speed Analyzer only for debugging / testing purposes. If you leave it on, it'll keep generating reports on every page load (causing unnecessary overhead).

It's good to know there's a potential conflict with the replace_link_with_first_in_nav attribute.

@patej
Copy link
Author

patej commented Oct 8, 2018

Yeah I enabled only for a while, but on a production site to try to figure out some things, so the change in how site functioned caught me and some others by surprise. Don't know if you can do anything about it, but might be good to add it as an information somewhere. Thanks for a useful add-on, anyway!

@a3020
Copy link
Owner

a3020 commented Oct 8, 2018

I just tested this on an 841 instance and can't replicate the issue. Also, that attribute is meant to replace a link in the autonav block, it doesn't do redirection by itself. I don't see any indication to why this would cause issues to be honest.

@patej
Copy link
Author

patej commented Oct 8, 2018

Sorry I failed to mention that I have the redirection defined for pages with this attribute if the page is visited manually, too, as explained here: https://documentation.concrete5.org/tutorials/redirect-link-first-child-pages so that's the thing that breaks, then, I guess..

@a3020
Copy link
Owner

a3020 commented Oct 8, 2018

I set up that custom event, went to the page directly, and got redirected while SA is enabled.

@a3020 a3020 closed this as completed Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants