-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed Analyzer blocks replace_link_with_first_in_nav #8
Comments
Thanks for reporting. I'd probably recommend enabling Speed Analyzer only for debugging / testing purposes. If you leave it on, it'll keep generating reports on every page load (causing unnecessary overhead). It's good to know there's a potential conflict with the |
Yeah I enabled only for a while, but on a production site to try to figure out some things, so the change in how site functioned caught me and some others by surprise. Don't know if you can do anything about it, but might be good to add it as an information somewhere. Thanks for a useful add-on, anyway! |
I just tested this on an 841 instance and can't replicate the issue. Also, that attribute is meant to replace a link in the |
Sorry I failed to mention that I have the redirection defined for pages with this attribute if the page is visited manually, too, as explained here: https://documentation.concrete5.org/tutorials/redirect-link-first-child-pages so that's the thing that breaks, then, I guess.. |
I set up that custom event, went to the page directly, and got redirected while SA is enabled. |
This add-on seems to block the "replace_link_with_first_in_nav" attribute from working, at least on Concrete5 8.4.2. The redirection had suddenly stopped working, but after disabling Speed Analyzer it started to work again.
The text was updated successfully, but these errors were encountered: