Sql2o should not be dependend on jodatime

[aaberg]

instead, it should use jodatime if available.

[aldenquimby]

I'm not too familiar with maven, but does this just mean adding <optional>true</optional> to the joda time dependency in the sql2o pom?

[aaberg]

Hmm. Could it be that easy?
I will try it right away. Test it a bit and see if it works.

[aldenquimby]

So I just tried it out, and I think it works.

After reading this article, it might make sense to approach a lot of things like flyway does. I don't know if you are familiar with flyway, but it's a database migration library that has a similar situation with optional dependencies on many different database implementations.

Easiest way to handle it seems to be have optional dependencies, and check for existence at run time, which you are already doing with joda's DateTime in Convert.java. The article I linked above includes a useful utility for dealing with this:

public static boolean isPresent(String className) {
    try {
        Class.forName(className);
        return true;
    } catch (Throwable ex) {
        return false;
    }
}

...

if (isPresent("com.optionaldependency.DependencyClass")) {
    // This block will never execute when the dependency is not present
    executeCodeLinkingToDependency();
}

[aaberg]

Nice, this is definitely the way to go. I will assign you to this ticket, then I will try to do something similar with the slf4j dependency.

I think we should cache the result of the isPresent method after it has run, I suspect it may have a performance issue if not. Something like this:

private Boolean present = null;
public static boolean isPresent(String className) {
    if (present == null) {
        try {
            Class.forName(className);
            present = true;
        } catch (Throwable ex) {
            present = false;
        }
    }
    return present;
}

[aldenquimby]

Ok great. Looks like this strategy will work for dealing with Convert.java, but it will not work with addParameter(String name, DateTime value) in Query.java. I will look into possible solutions and send you a pull request for review when I'm done

[aaberg]

I have a suggestion:
I think it will work to just remove the addParameter(String, DateTime) method, and detect and handle jodatime parameters within the addParameter(String, Object) method.