Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcGenMod is clashing with Sverchok "search" #27

Closed
enzyme69 opened this issue May 14, 2019 · 6 comments
Closed

ProcGenMod is clashing with Sverchok "search" #27

enzyme69 opened this issue May 14, 2019 · 6 comments
Labels
question Further information is requested

Comments

@enzyme69
Copy link

Not sure how this can be handled, you might need to talk to SV developers.

But I found that your ProcGenMod is clashing with Sverchok Search.

Traceback (most recent call last):
  File "/Users/jimmyg/Library/Application Support/Blender/2.79/scripts/addons/sverchok-master-6/utils/sv_extra_search.py", line 165, in invoke
    loop['results'] = gather_items()
  File "/Users/jimmyg/Library/Application Support/Blender/2.79/scripts/addons/sverchok-master-6/utils/sv_extra_search.py", line 108, in gather_items
    fx.append((str(idx), ensure_valid_show_string(item), '', idx))
  File "/Users/jimmyg/Library/Application Support/Blender/2.79/scripts/addons/sverchok-master-6/utils/sv_extra_search.py", line 66, in ensure_valid_show_string
    description = nodetype.bl_rna.get_shorthand()
AttributeError: 'Node' object has no attribute 'get_shorthand'

location: <unknown location>:-1

Also on the other hand, ProcGenMod "search" does not work on Blender version 2.79 latest.

@aachman98 aachman98 added the bug Something isn't working label May 14, 2019
@aachman98
Copy link
Owner

File "/Users/jimmyg/Library/Application Support/Blender/2.79/scripts/addons/sverchok-master-6/utils/sv_extra_search.py", line 66, in ensure_valid_show_string
description = nodetype.bl_rna.get_shorthand()

This is the description of nodes in the Sverchok search menu (after hovering on a selection). It probably calls this method on all node classes irrespective of node type, thus generating error when it encounters one of the ProcGenMod classes as none of its nodes have a method named "get_shorthand()".

I can fix this error simply by creating a method of the same name in the base class and have it return an empty string, but that would result in Sverchok addon recognizing ProcGenMod's nodes as its own and probably listing them in its search menu.

Alternatively, I can edit the sverchok code and generate a PR to avoid this error.

@aachman98
Copy link
Owner

Sverchok error

@aachman98
Copy link
Owner

aachman98 commented Jun 4, 2019

Changed the node category identifier in v2.0.1 (commit: 7a18803). Please let me know if it's clashing with Sverchok still.

@aachman98 aachman98 added the question Further information is requested label Jun 4, 2019
@stansu
Copy link

stansu commented Jun 5, 2019

still clashing

@aachman98 aachman98 added help wanted Extra attention is needed and removed question Further information is requested labels Jun 5, 2019
@aachman98 aachman98 added wontfix This will not be worked on and removed help wanted Extra attention is needed labels Jul 12, 2019
@enzyme69
Copy link
Author

I tested just now with 2.79, the clashing was happening the other day when I already have Sverchok and then install Sorcar.

If I add Sverchok while Blender is running with Sorcar, Search in Sverchok works.

But I also notice on Mac, there are few Blender versions where Sorcar SEARCH works and not working. Pretty annoying bug there...

@aachman98
Copy link
Owner

Is this still an issue in the v3?

@aachman98 aachman98 added question Further information is requested and removed bug Something isn't working wontfix This will not be worked on labels Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants