Possibility to customize the default prompt text to describe an image #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @Nael-Sayegh! I suggest the following key/attribute renamings:
|
AAClause
reviewed
Dec 6, 2023
| self.default_prompt = imageGroup.addItem( | ||
| wx.CheckBox( | ||
| imageBox, | ||
| label=_("Use a default custom text in the prompt to describe images") |
There was a problem hiding this comment.
Suggested change
| label=_("Use a default custom text in the prompt to describe images") | |
| label=_("Customize default text &prompt") |
There was a problem hiding this comment.
I disagree with this modification because it's not clear enough for the user. It should be specified that it is for the image description.
AAClause
reviewed
Dec 6, 2023
| self.default_prompt.SetValue(config.conf["OpenAI"]["images"]["default_prompt"]) | ||
|
|
||
| self.default_prompt_text = imageGroup.addLabeledControl( | ||
| _("Custom text"), |
There was a problem hiding this comment.
Suggested change
| _("Custom text"), | |
| _("Default &text prompt:"), |
AAClause
reviewed
Dec 6, 2023
| @@ -380,6 +379,10 @@ def __init__( | |||
| ): | |||
| if not client or not conf: | |||
| return | |||
| if config.conf["OpenAI"]["images"]["default_prompt"]: | |||
There was a problem hiding this comment.
Suggested change
| if config.conf["OpenAI"]["images"]["default_prompt"]: | |
| if conf["images"]["useCustomDefaultPrompt"]: |
… key and variable names to be more precise.
|
Hello, |
Nael-Sayegh
force-pushed
the
default-description-prompt
branch
from
270f564
to
d731cf2
Compare
AAClause
reviewed
Dec 9, 2023
AAClause
reviewed
Dec 9, 2023
AAClause
reviewed
Dec 9, 2023
AAClause
reviewed
Dec 9, 2023
AAClause
reviewed
Dec 9, 2023
Co-authored-by: André-Abush Clause <dev@andreabc.net>
Co-authored-by: André-Abush Clause <dev@andreabc.net>
Co-authored-by: André-Abush Clause <dev@andreabc.net>
Co-authored-by: André-Abush Clause <dev@andreabc.net>
Co-authored-by: André-Abush Clause <dev@andreabc.net>
AAClause
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a checkbox to the settings panel to change the default prompt text for image description.
Fixes #17