Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for supplied and default parameter collision #19

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

maxmynter
Copy link
Collaborator

@maxmynter maxmynter commented Jan 24, 2024

Log warnings when a default value of a function is in the supplied parameters of the benchmark.

@maxmynter maxmynter marked this pull request as ready for review January 24, 2024 12:08
Copy link
Collaborator

@nicholasjng nicholasjng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

src/nnbench/runner.py Outdated Show resolved Hide resolved
maxmynter and others added 2 commits January 24, 2024 13:52
Co-authored-by: Nicholas Junge <n.junge@appliedai.de>
@maxmynter maxmynter merged commit fff162d into main Jan 24, 2024
5 checks passed
@nicholasjng nicholasjng deleted the collision-warning branch January 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants