Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method for notebooks and docs #191

Open
1 task
mdbenito opened this issue Nov 8, 2022 · 3 comments
Open
1 task

New method for notebooks and docs #191

mdbenito opened this issue Nov 8, 2022 · 3 comments
Assignees
Labels
cleanup when code is ugly or unreadable and needs restyling documentation Improvements or additions to documentation
Milestone

Comments

@mdbenito
Copy link
Collaborator

mdbenito commented Nov 8, 2022

We cannot keep pushing notebooks with outputs for documentation. The obvious solution is to use git LFS but then we need to clean up the history and force push.

  • Test in pipelines whether LFS things were pushed to git
@mdbenito mdbenito added documentation Improvements or additions to documentation High Priority! cleanup when code is ugly or unreadable and needs restyling labels Nov 8, 2022
@mdbenito mdbenito self-assigned this Mar 8, 2023
@mdbenito
Copy link
Collaborator Author

mdbenito commented Mar 8, 2023

Tested in https://github.com/mdbenito/pyDVL. I'll wait until we've merged all PRs and discarded any stale branches

@mdbenito
Copy link
Collaborator Author

mdbenito commented Mar 8, 2023

For the record, checkout seems not to pull LFS files despite lfs: true. Explicitly calling git lfs pull solves it of course. 🤷🏽

I take that back. It was bfg not creating the .gitattributes properly (it incorrectly (?) adds braces around the file extension)

Steps to take:

  1. Follow the steps here
  2. Fix the .gitattributes removing the braces
  3. add lfs: true to the checkout options in all github workflows

@mdbenito mdbenito removed their assignment Aug 26, 2023
@mdbenito mdbenito modified the milestones: v0.8.0, v0.9.0 Aug 26, 2023
@mdbenito mdbenito modified the milestones: v0.10.0, v0.9.0 Apr 6, 2024
@mdbenito
Copy link
Collaborator Author

mdbenito commented Apr 6, 2024

We need to do this ASAP, even if we don't use bfgs. We can just track notebooks in lfs and git add --renormalize . in the root. The history will still contain the stupid blobs from the past, but this is unsustainable.

@mdbenito mdbenito self-assigned this Apr 6, 2024
@mdbenito mdbenito modified the milestones: v0.9.0, v0.9.1 Apr 19, 2024
@mdbenito mdbenito modified the milestones: v0.9.1, v0.10.0 May 3, 2024
@schroedk schroedk modified the milestones: v0.10.0, v0.11.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup when code is ugly or unreadable and needs restyling documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants