Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebooks #2

Closed
mdbenito opened this issue May 20, 2022 · 4 comments
Closed

Fix notebooks #2

mdbenito opened this issue May 20, 2022 · 4 comments
Assignees
@Xuzzo
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone
Initial documenta...

Comments

@mdbenito
Copy link
Collaborator

They should run without problems (adapt to new changes in the code). See #1
@mdbenito mdbenito added bug Something isn't working documentation Improvements or additions to documentation labels May 20, 2022
@mdbenito mdbenito modified the milestones: Scaffolding, 90% coverage May 20, 2022
@mdbenito mdbenito mentioned this issue May 20, 2022
Closed
4 tasks
@AnesBenmerzoug AnesBenmerzoug mentioned this issue May 29, 2022
Merged
@mdbenito
Copy link
Collaborator Author

@Xuzzo Does your PR finish fixing this? Maybe add to its description.

@mdbenito mdbenito removed this from the Full test coverage of valuation algorithms milestone Jun 28, 2022
@AnesBenmerzoug
Copy link
Collaborator

@Xuzzo are any of your branches related to this?

@Xuzzo
Copy link
Collaborator

Xuzzo commented Aug 18, 2022

Issue #91 was part of it. The KNN shapley notebook is what remains to do for this issue

@Xuzzo
Copy link
Collaborator

Xuzzo commented Sep 28, 2022

Closed by #127

@Xuzzo Xuzzo closed this as completed Sep 28, 2022
@mdbenito mdbenito added this to the Initial documentation milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xuzzo Xuzzo

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
Initial documentation
Development

No branches or pull requests
3 participants
@mdbenito @AnesBenmerzoug @Xuzzo