Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Bugs #1

Closed
xixy opened this issue Jul 10, 2021 · 1 comment
Closed

Code Bugs #1

xixy opened this issue Jul 10, 2021 · 1 comment

Comments

@xixy
Copy link

xixy commented Jul 10, 2021

Thanks for your open-sourced project about this work.

However, when running the code, I find some bugs to fix. For example, checkout Line.234 in tester.py, the declaration about model is incorrect and should be modified as follow

model = EventExtractor(len(list(sent_vocab.keys())), args.emb_size, args.hidden_size, 1, args.dropout, args.bidir, args.model, pos_vocab_size=len(list(pos_vocab.keys())))

otherwise the code fails because len(list(pos_vocab.keys()))) is recognized as argument for num_layers and the pos_vocab_size is None.

@aakanksha19
Copy link
Owner

Thanks a lot for pointing that out! Looks like that was an issue in both tester.py and da_tester_new.py. I've fixed the bug now, so the code should work without any further issues, but please let me know if you run into something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants