Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsAnagram logic needs to be fixed #11

Open
harsh-athalye opened this issue Aug 20, 2015 · 1 comment
Open

IsAnagram logic needs to be fixed #11

harsh-athalye opened this issue Aug 20, 2015 · 1 comment
Assignees
Labels
bug Report an issue with the project good first issue

Comments

@harsh-athalye
Copy link

I think the IsAnagram() method doesn't work as expected. For example, it would fail for the below string combinations ("abc","bbb") or ("acdf", "bcde").

I think a simple LINQ implementation would be easy enough to implement here.
If you like, I could do that and also implement unit tests for it.

@aalhour
Copy link
Owner

aalhour commented Aug 20, 2015

Hi, thanks for your comment. I am well aware of that issue but haven't pushed the new fixes yet. I would like to know your comment regarding the new changes when I push them, so please do keep checking it.

On a side note, I think it would be more meaningful (from an educational standpoint) to have an algorithmic implementation that doesn't depend on LINQ, since you don't exactly know what happens under the hood. :)

@aalhour aalhour closed this as completed Aug 20, 2015
@aalhour aalhour self-assigned this Nov 1, 2019
@aalhour aalhour added bug Report an issue with the project good first issue and removed question labels Nov 1, 2019
@aalhour aalhour reopened this Nov 1, 2019
itai192 referenced this issue Sep 25, 2020
this is my first commit to a public repo, so i don't know if i'm doing it right
@itai192 itai192 mentioned this issue Sep 25, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report an issue with the project good first issue
Projects
None yet
Development

No branches or pull requests

2 participants