Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch button show the correct number #56

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Watch button show the correct number #56

merged 1 commit into from
Jul 10, 2017

Conversation

PoLaKoSz
Copy link
Contributor

@PoLaKoSz PoLaKoSz commented Jul 8, 2017

Fixed #55

@PoLaKoSz
Copy link
Contributor Author

PoLaKoSz commented Jul 8, 2017 •
edited
Loading

Please not merge yet if looks good for you, because I want to dive deeper why something broken in
OctoKit.NET.

@PoLaKoSz
Copy link
Contributor Author

PoLaKoSz commented Jul 8, 2017

Created an issue on OctoKit hope I get an answer. :)

@PoLaKoSz
Copy link
Contributor Author

PoLaKoSz commented Jul 9, 2017

It's really sad, I think the original GitHub API is the reason why the UI shows the wrong number (OctoKit.NET)
If you reviewed my code and fine I won't add more code to it so you can merge it.

@aalok05 aalok05 merged commit 1ec4755 into aalok05:dev Jul 10, 2017
@aalok05
Copy link
Owner

aalok05 commented Jul 10, 2017 •
edited
Loading

Made some changes here 3327893 . We'll get a new repository object only when SubscribersCount is 0. This way we have to call the API method fewer times.

@PoLaKoSz
Copy link
Contributor Author

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PoLaKoSz @aalok05