Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge web_ui into templates? #18

Closed
BanjoFox opened this issue Nov 30, 2017 · 3 comments
Closed

Merge web_ui into templates? #18

BanjoFox opened this issue Nov 30, 2017 · 3 comments

Comments

@BanjoFox
Copy link
Collaborator

Given that PR #17 is putting all of the Rocket web templates into the /templates directory does it make sense to "clean up" the /web_ui directory?

Right now it doesn't really contain anything terribly meaningful other than some sandboxing, which can be easily moved/merged into the appropriate *.hbs files that Rocket understands.

I was also going to add the other asset folders as such:

/templates
../emojo
../images
../javascript
../stylesheets
../themes

@BanjoFox
Copy link
Collaborator Author

BanjoFox commented Dec 1, 2017

Proposed changes have been made as part of web-dev branch.

@pwoolcoc
Copy link

pwoolcoc commented Dec 1, 2017

/templates is just the default that Rocket.rs expects, it can be changed to whatever we want.

I'd suggest not putting non-html-templates into that directory. We could probably keep the rest (stylesheets, javascript, etc) in the /web_ui directory, or a /public directory or something, since they have nothing to do with the Rocket.rs templating system.

@BanjoFox
Copy link
Collaborator Author

BanjoFox commented Dec 1, 2017

Ahah! That makes a lot of sense... I will update web-dev accordingly :)

@BanjoFox BanjoFox closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants