Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing data in Activity series consistently. #1

Open
aaron-schroeder opened this issue Dec 10, 2019 · 0 comments
Open

Handle missing data in Activity series consistently. #1

aaron-schroeder opened this issue Dec 10, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@aaron-schroeder
Copy link
Owner

aaron-schroeder commented Dec 10, 2019

Most time series fields in a device activity file can have some missing values within the time series. Cadence, heart rate, coordinates, elevation etc. This is typically due to some sensor issue - an inability to access the GPS device or heart rate monitors.

When data is read in from a *FileReader into an Activity, algorithms do their best to infer the true value of these missing values using other available fields, but there are values that cannot be inferred and must remain null values. These values remain in the underlying DataFrame cells.

Currently, these missing DataFrame cell values are handled inconsistently between methods to access each field. Null cadence values are not included in the returned series, while null distance values are included. This creates mismatches when individual Series are used side-by-side. On my website, the cadence series often has less values than the lat-lon series because of the differences in how each is handled. This activity has the unwanted behavior, but the website is in between builds currently and does not draw the chart. The behavior will be clear when this is fixed.

I know that methods like mean_cadence currently will malfunction if they are asked to average null values, but I don't think that is a good reason to pre-process the output of the cadence series method. I think the mean/norm functions should handle the raw series that the methods return.

I am opening this issue to document the process of making the time series fields behave consistently. Also because I want to learn how to use github issues.

@aaron-schroeder aaron-schroeder self-assigned this Dec 10, 2019
@aaron-schroeder aaron-schroeder added the bug Something isn't working label Dec 19, 2019
@aaron-schroeder aaron-schroeder added this to the v0.0.20 release milestone Dec 19, 2019
@aaron-schroeder aaron-schroeder removed this from the v0.0.20 release milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant