Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_bson_append_xxxx_tarray methods should take pointers to TArray<XXXX> #1

Open
aaronsnoswell opened this issue Jan 11, 2018 · 0 comments
Open

_bson_append_xxxx_tarray methods should take pointers to TArray<XXXX> #1

aaronsnoswell opened this issue Jan 11, 2018 · 0 comments

Comments

@aaronsnoswell
Copy link
Owner

Currently these methods, e.g. (_bson_append_double_tarray at https://github.com/aaronsnoswell/ROSIntegration/blob/master/Source/ROSIntegration/Private/Conversion/Messages/BaseMessageConverter.h#L68) take a pass by value. This could have a performance hit for large TArrays. I should change this to a pointer or pass by reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronsnoswell