Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim the screen when click on skittle ? #9

Closed
devabir93 opened this issue Sep 17, 2015 · 10 comments
Closed

Dim the screen when click on skittle ? #9

devabir93 opened this issue Sep 17, 2015 · 10 comments

Comments

@devabir93
Copy link

No description provided.

@ghost
Copy link

ghost commented Sep 17, 2015

Hmm yeah a needed feature, might take me some time to do this, bit busy, pull request welcome

@devabir93
Copy link
Author

waitin.. :D

@polok
Copy link

polok commented Jan 22, 2016

Just to let you know that I am working on this feature and PR should be ready on Sunday ;)

@ghost ghost added the enhancement label Jan 23, 2016
@ghost ghost added this to the v3.1.1 milestone Jan 23, 2016
@ghost
Copy link

ghost commented Jan 23, 2016

@polok hey take a look at #15 I think it needs to be done and this issue can be easily completed afterwards, lets move the discussion there

@ghost
Copy link

ghost commented Feb 5, 2016

@polok take a look at the new version 4.0.0 or in the master branch, the api has been changed and is now backed by RecyclerView, If you are interested you can open a new pull request with these changes with respect to the new api

@ghost ghost closed this as completed Feb 5, 2016
@polok
Copy link

polok commented Feb 5, 2016

@aashrairavooru Thanks for letting me know. I will have a look for sure but don't know exactly when, quite many things to do in my to-do list for now :/

@ghost
Copy link

ghost commented Feb 5, 2016

NP man, would love feedback on the rewritten api as well
On 23-Jan-2016 3:15 AM, "polok" notifications@github.com wrote:

Just to let you know that I am working on this feature and PR should be
ready on Sunday ;)


Reply to this email directly or view it on GitHub
#9 (comment)
.

@ghost
Copy link

ghost commented Feb 5, 2016

@polok best if you make a pull on the dev branch I might push some changes before you make your pull request on sunday

@polok
Copy link

polok commented Feb 12, 2016

@aashrairavooru I made a quick look on your latest changes. They are really cool, there was a good idea to use recyclerview. Next week I will adopt these changes to my implementation of 'shadow' effect and I will prepare PR.

@ghost
Copy link

ghost commented Feb 12, 2016

Thanks man, looking forward to it

On Fri, Feb 12, 2016 at 6:17 PM, polok notifications@github.com wrote:

@aashrairavooru https://github.com/aashrairavooru I made a quick look
on your latest changes. They are really cool, there was a good idea to use
recyclerview. Next week I will adopt these changes to my implementation of
'shadow' effect and I will prepare PR.


Reply to this email directly or view it on GitHub
#9 (comment)
.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants