Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Location Permission and Storage Permission flow #177

Merged
merged 18 commits into from
Jul 13, 2021
Merged

Adjust Location Permission and Storage Permission flow #177

merged 18 commits into from
Jul 13, 2021

Conversation

zafodB
Copy link
Collaborator

@zafodB zafodB commented Jul 8, 2021

This PR contains several major changes to permission logic, focusing on Location and Storage permissions:

  • A new class CustomLocationManager is introduced to centrally handle all location-related actions. Requesting permissions from the user is handled here.
  • The location permission request flow is adjusted to display Location Permission rationale before requesting the location (to satify Play Store requirement)
  • App start-up flow is adjsuted so that the Location permissions don't overlap with Privacy Policy dialog
  • Storage permission is not requested anymore for saving logs, instead the user is prompted to select the location when saving the log.

zafodB added 15 commits July 2, 2021 12:23
@zafodB
some initial progress on file save changes
5c8340f
@zafodB
formatting changes
655a9d3
@zafodB
align variable naming and adjust export formats
ffd31c6
@zafodB
cleanup and write comments
2432f11
@zafodB
extract location permission strings
e2572b0
@zafodB
formatting changes
ea2d95d
@zafodB
adjust application flow on first open (so that pop-ups don't overlap).
8de3969
@zafodB
fix some nullpointer exceptions that were thrown when user did not im…
512267f 
…mediately grant location permissions
@zafodB
WIP: location request flow update
6c2ce16
@zafodB
rewrite a generic exception catch block
ac1aeb4
@zafodB
Write new FilipsLocationManager to handle location-related stuff and …
05a6e2a 
…adopt it's use across the app (except ThreatMapFragment)
@zafodB
formatting changes
f11eb49
@zafodB
basic map and location functionality working.
13fa8aa
@zafodB
Clean up, write comments. Further adoption of CustomLocationManager
6ad6877
@zafodB
bump gradle to newer version
2bd4983
@zafodB zafodB added the Major Major Release Feature label Jul 8, 2021
@zafodB zafodB requested a review from sastry17 July 8, 2021 11:12
@zafodB zafodB self-assigned this Jul 8, 2021
@zafodB zafodB linked an issue Jul 8, 2021 that may be closed by this pull request
Android 11 Location Permissions and Privacy Policy update #108
Closed
@zafodB
Copy link
Collaborator Author

zafodB commented Jul 8, 2021

The app should now be displaying the Prominent disclosure popup, warning the user why the location is being requested. The exact wording of this warning may need to be adjusted further.

@sastry17
Copy link
Collaborator

sastry17 commented Jul 8, 2021

updated google-services.json to enable firebase sync

@sastry17 sastry17 linked an issue Jul 13, 2021 that may be closed by this pull request
Change icon of Privacy Menu item #179
Closed
@sastry17
changed privacy policy icon
05d438a 
changed privacy policy icon
@zafodB zafodB merged commit e5e2a8b into ver-2.4(major) Jul 13, 2021
@zafodB zafodB deleted the permission-update branch July 13, 2021 08:58
@zafodB zafodB mentioned this pull request Jul 13, 2021
Closed
@sastry17 sastry17 added the ver:2.4 HosTaGe v.2.4 label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastry17 sastry17 Awaiting requested review from sastry17

Assignees

@zafodB zafodB

Labels
Major Major Release Feature ver:2.4 HosTaGe v.2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change icon of Privacy Menu item Android 11 Location Permissions and Privacy Policy update
2 participants
@zafodB @sastry17