Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Adjustments #202

Merged
merged 13 commits into from
Jul 23, 2021
Merged

UI Adjustments #202

merged 13 commits into from
Jul 23, 2021

Conversation

zafodB
Copy link
Collaborator

@zafodB zafodB commented Jul 21, 2021

Further adjustments to UI, particulalry in relation to theming. Important changes:

  • Wider adoption of dark mode - Dark mode has been adopted in several new fragments and UI elements, such as attack record details, filters, statistics
  • Accessibility adjustments in light mode and dark mode - both light and dark theme were adjusted to avoid unreadable text in UI (light colour text on light background/dark colour text on dark background)
  • Simplified and streamlined colour adjustment - app theming has been adjusted to allow simpler modification of color theme. In this version, theme can be adjusted by changing colorPrimary and colorPrimaryVariant in colors.xml, separately for light mode and dark mode.
  • Action buttons moved to Action Bar - action buttons, such as filter, group, or delete were moved from a custom bar on the bottom of the screen to a more usual location in the Action bar (top right of the screen). This affects RecordOverviewFragment, RecordDetailFragment and StatisticsFragment.
  • Date and time selection adjusted - date and time selection fragment, displayed when applying filters in the Records or Statistics screen has been replaced by a flow: a date picker is displayed, and only after the user has selected a date, a time picker is displayed. After the user has selected time, the value is passed to the filter.

Fixes #178

@zafodB zafodB added bug Something isn't working Major Major Release Feature ver:2.4 HosTaGe v.2.4 labels Jul 21, 2021
@zafodB zafodB requested a review from sastry17 July 21, 2021 12:04
@zafodB zafodB self-assigned this Jul 21, 2021
@zafodB zafodB added this to In progress in GSoC-2021 via automation Jul 21, 2021
@zafodB zafodB linked an issue Jul 21, 2021 that may be closed by this pull request
Copy link
Collaborator

@sastry17 sastry17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes tested and approved.

GSoC-2021 automation moved this from In progress to Reviewer approved Jul 22, 2021
@zafodB zafodB merged commit b2e896e into ver-2.4(major) Jul 23, 2021
GSoC-2021 automation moved this from Reviewer approved to Done Jul 23, 2021
@zafodB zafodB deleted the ui-darkmode branch July 23, 2021 07:57
@sastry17 sastry17 moved this from Done to Release in GSoC-2021 Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Major Major Release Feature ver:2.4 HosTaGe v.2.4
Projects
GSoC-2021
Release
Development

Successfully merging this pull request may close these issues.

Change Color Scheme (Pink)
2 participants