Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of steps is missing from the dialog #180

Closed
foodaka opened this issue Feb 17, 2022 · 6 comments
Closed

Number of steps is missing from the dialog #180

foodaka opened this issue Feb 17, 2022 · 6 comments

Comments

@foodaka
Copy link
Collaborator

foodaka commented Feb 17, 2022

Reported By

  • Aave community member

Having the number of steps missing is not as intuitive for the user with the two buttons one disabled on enabled.
Screen Shot 2022-02-17 at 11 43 42 AM

@foodaka
Copy link
Collaborator Author

foodaka commented Feb 17, 2022

personally i agree with this, having the two steps makes it more clear the total flow for the user. i preferred the small -> we had in the initial designs

@iamanastasia
Copy link
Contributor

I feel like it's the matter of preference.

We've referenced Uniswap and Zapper here, to stay consistent, at least externally.
Adding stepper is not easy in our case, because number of steps is different for every transaction. Besides it's just 2 steps = 2 buttons. And initial idea of changing tx flow was to simplify it, and remove steps.

Let's get more feedback here, to see how easy/difficult these steps are.

@sendra
Copy link
Collaborator

sendra commented Feb 18, 2022

Maybe we could add the number on the button, like:
1 - Approve to continue
2 - Supply USDT
And when there is no approval just show supply USDT

With that and the disabled supply when button 1 is not done it should be clear enough that you need to do both

(I think though that its not needed. that showing both buttons is enough)

@The-3D
Copy link

The-3D commented Feb 18, 2022

i see this two buttons pattern for approvals everywhere (uniswap, 1inch, paraswap, compound just to mention a few) and to be honest I don't feel like its unclear, most users are used to it
to me its clear enough if we don't do anything, if we want to do something the less invasive the better
maybe what @sendra proposed can be a good middle ground

@The-3D
Copy link

The-3D commented Feb 18, 2022

also the button clearly says "approve to continue", it is pretty clear to me to be honest

@foodaka
Copy link
Collaborator Author

foodaka commented Feb 22, 2022

As per feedback closing out

@foodaka foodaka closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants