-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of steps is missing from the dialog #180
Comments
personally i agree with this, having the two steps makes it more clear the total flow for the user. i preferred the small -> we had in the initial designs |
I feel like it's the matter of preference. We've referenced Uniswap and Zapper here, to stay consistent, at least externally. Let's get more feedback here, to see how easy/difficult these steps are. |
Maybe we could add the number on the button, like: With that and the disabled supply when button 1 is not done it should be clear enough that you need to do both (I think though that its not needed. that showing both buttons is enough) |
i see this two buttons pattern for approvals everywhere (uniswap, 1inch, paraswap, compound just to mention a few) and to be honest I don't feel like its unclear, most users are used to it |
also the button clearly says "approve to continue", it is pretty clear to me to be honest |
As per feedback closing out |
Reported By
Having the number of steps missing is not as intuitive for the user with the two buttons one disabled on enabled.
The text was updated successfully, but these errors were encountered: