Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Method name possession/possesions doesn't sound 'right' #60

Closed
rht opened this issue Jul 8, 2017 · 4 comments
Closed

Method name possession/possesions doesn't sound 'right' #60

rht opened this issue Jul 8, 2017 · 4 comments

Comments

@rht
Copy link
Member

rht commented Jul 8, 2017

Methods are meant to be verb. agent17.get_good("neutrino") reads better as a sentence than agent17.possession("neutrino").
@DavoudTaghawiNejad
Copy link
Member

resolved with the self['neutrino'] notation

@rht
Copy link
Member Author

rht commented Nov 18, 2017

self['neutrino'], while it can be implemented in Python, is not cross-language if supposedly there will be multiple lang implementation of ABCE.

@DavoudTaghawiNejad
Copy link
Member

I think get_good or get_goods should be implemented as well

@DavoudTaghawiNejad
Copy link
Member

I replaced possessions with goods in panel_log and agg_log.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rht @DavoudTaghawiNejad