Dump prone MESSAGE statement

[dycsi-gabrielbaca]

In method EXPORT_TO_TABLE of class ZCL_LOGGER, there is a MESSAGE statement in line 29 that generates a short dump whenever a message with no reference to a message class was used. Therefore, the method is not useful for any case no message classes are used.

I performed a manual correction in my system just like this:

    IF message-msgty IS NOT INITIAL.
      MESSAGE ID message-msgid
                      TYPE message-msgty
                      NUMBER message-msgno
                      INTO bapiret2-message
                      WITH message-msgv1 message-msgv2 message-msgv3 message-msgv4.
    ENDIF.

[epeterson320]

Hey, thanks so much for finding this. That's definitely a problem. Would you mind submitting your fix in a PR?

[alpex8]

@dycsi-gabrielbaca could you please clarify what lead to the error on your side, as I tried to reproduce it.
What I did was as follows:

DATA(logger) = /bitgrp/cl_bal_logger=>new( object = 'MYOBJECT' subobject = 'MYSUB' ).
logger->s( 'foo' ).
data(table) = logger->export_to_table( ).

This was working and the message class of my message was set to BL, number was 1. The content of this message in the class is & & & &

[dycsi-gabrielbaca]

Actually I later found out it was a misuse of the ADD method. I basically did this: logger->add( 'This is a test message' ). And while it does add the message to the application log, it is an incomplete message.

…

On Wed, Oct 11, 2017 at 1:27 AM apex8 ***@***.***> wrote: @dycsi-gabrielbaca <https://github.com/dycsi-gabrielbaca> could you please clarify what lead to the error on your side, as I tried to reproduce it. What I did was as follows: DATA(logger) = /bitgrp/cl_bal_logger=>new( object = 'MYOBJECT' subobject = 'MYSUB' ). logger->s( 'foo' ). data(table) = logger->export_to_table( ). This was working and the message class of my message was set to BL, number was 1. The content of this message in the class is & & & & — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APV-_SepN3fephR1FqNv5phre8PA8S9hks5srF-6gaJpZM4PoEfy> .

-- Este mensaje y sus adjuntos se dirigen exclusivamente a su destinatario, puede contener información privilegiada y/o confidencial y es para uso exclusivo de la persona o entidad de destino. Si usted no es el destinatario indicado, queda notificado que la lectura, utilización, divulgación y/o copia sin autorización puede estar prohibida en virtud de la legislación vigente. Si ha recibido este mensaje por error, le rogamos nos informe inmediatamente por esta misma vía y proceda a su destrucción. Aviso de Privacidad <http://dycsi.com.mx/aviso-de-privacidad/>

-- Este mensaje y sus adjuntos se dirigen exclusivamente a su destinatario, puede contener información privilegiada y/o confidencial y es para uso exclusivo de la persona o entidad de destino. Si usted no es el destinatario indicado, queda notificado que la lectura, utilización, divulgación y/o copia sin autorización puede estar prohibida en virtud de la legislación vigente. Si ha recibido este mensaje por error, le rogamos nos informe inmediatamente por esta misma vía y proceda a su destrucción. Aviso de Privacidad <http://dycsi.com.mx/aviso-de-privacidad/>