Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to check data integrity of archived files #26

Closed
amosavian opened this issue Jul 27, 2015 · 6 comments
Closed

Add method to check data integrity of archived files #26

amosavian opened this issue Jul 27, 2015 · 6 comments
Assignees
@abbeycode
Labels
enhancement
Milestone
2.9

Comments

@amosavian
Copy link

it is nice to have a separate method for checkIntegrity via this RAR_TEST option.
also for UnzipKit via CRC check
@abbeycode abbeycode changed the title test archive Add method to check data integrity of archived files Jul 30, 2015
@abbeycode
Copy link
Owner

Thanks for the suggestion. I'll take a look when I have some time.

@amosavian
Copy link
Author

Any news :D

@abbeycode
Copy link
Owner

Nope, not yet – been busy with other tasks. I'm always open to pull requests, though :D

@amosavian
Copy link
Author

I forgot it, found this after new GitHub update

@abbeycode abbeycode mentioned this issue Oct 7, 2017
Merged
@abbeycode
Copy link
Owner

Hey man, I finally got around to this. Check out PR #61 and let me know what you think! It turns out that the RAR_TEST command doesn't do what it sounds like. It just reads the file's data without extracting it. So I implemented it the way it'll most likely work in UnzipKit too, which is to extract and checksum the extracted data.

@abbeycode abbeycode mentioned this issue Oct 7, 2017
Closed
@abbeycode abbeycode added this to the 2.9 milestone Oct 11, 2017
@abbeycode abbeycode self-assigned this Oct 11, 2017
@abbeycode
Copy link
Owner

Merged! It'll be included in the next beta (2.9 beta 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abbeycode abbeycode

Labels
enhancement
Projects
None yet
Milestone
2.9
Development

No branches or pull requests
2 participants
@abbeycode @amosavian