-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request. Custom callback methods #33
Comments
In order to help design the API for this request, can you please provide some example use cases for this feature? |
https://github.com/fishman/rar_expander/blob/master/RarExpander.mm |
Thanks, that link's helpful, but I'd still like to know how you plan to use the feature. Why is that event useful to you? |
Sorry but I can't post my code. The only thing I can say is it handles something like error and in some cases returns -1 (failure) but the default implementation (including UnrarKit) always returns 0 even doesn't allow to handle this event without editing of the library's sources |
I'm not asking you to post code, I only mean why do you need this feature? Why is the As an example, for your other feature request, the answer could be "Because I'd like to show users of my app how much space a file will take up, so they can decide whether or not to extract it". I didn't ask for a use case for that feature, because I could picture use cases on my own. I don't currently see what you would use that callback for, so I'm asking you to help me understand. |
@gerchicov-bp I've addressed your other feature request. If you're able to help me understand this request better, I can include this along with it on the next release. |
anyways I've already created a block which is called inside this static callback method but this block is defined as public and I can always override/redefine it. |
Ok, feel free to submit a pull request to share back your contribution. I'm going to close this now - let me know if there's anything else I can do to help. |
int CALLBACK CallbackProc(UINT msg, long UserData, long P1, long P2)
int CALLBACK BufferedReadCallbackProc(UINT msg, long UserData, long P1, long P2)
These functions can be accessed from the code inside
URKArchive.mm
.What about to add a public way to access them? For example I want to customize
UCM_CHANGEVOLUME
eventThe text was updated successfully, but these errors were encountered: