-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/tags should give a list of tags #30
Comments
How would you get the list of tags ? Do you propose to walk KeyHashtbl and for each article to collect its tags ? Or should we get the tags directly from the Store module ? |
I'd naively walk the KeyHashtbl.. if it turns out to be a performance bottleneck, caching can be done later |
I guess walking through KeyHashtbl and building a Set of all tags is enough for now, yeah. We'll cache it one day if needed. |
Is this done statically or dynamically in the unikernel ? |
dynamically in the unikernel |
Then I'd rather use a |
Got this, even though I'm not too sure about how user-contributed the content really is. |
It may not even be possible to exploit this. It's just an algorithmic mindset: by using a Also as the software evolves that bit of code may end up being (re-)used in another context or c&p in other software without much thought, but in a use case where the problem may become relevant. In any case if you stick to hashtables it would be better to create the custom hashtable with |
I agree, I will then move to Map.Make, I don't see any problem in doing so, and @hannesm seems to agree too. |
issue #30 /tags should give a list of tags
currently it returns a not found
The text was updated successfully, but these errors were encountered: