Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: player lock has lost it's meaning (existential crises) #7

Closed
Brajesh3 opened this issue Aug 31, 2024 · 5 comments
Closed

Bug: player lock has lost it's meaning (existential crises) #7

Brajesh3 opened this issue Aug 31, 2024 · 5 comments

Comments

@Brajesh3
Copy link

You play a video then lock the player to prevent accidental touch

But you can still seek video &
change brightness & volume.
@abdallahmehiz
Copy link
Owner

Seems like the areControlsLocked state changing isn't affecting modifiers when recomposing for some reason. I've made the necessary changes for that not to happen and it'll be fixed soon. Thanks for the bug report 👍

@abdallahmehiz
Copy link
Owner

Should be fixed in 7cf5b4d

@Brajesh3
Copy link
Author

Is this by design or bug that 2x speed still works even when player locked

@abdallahmehiz
Copy link
Owner

Definitely a bug I didn't catch.
sleep deprived programming...
I'll be deleting the latest release and making a new one.

@Brajesh3
Copy link
Author

Brajesh3 commented Sep 1, 2024

Sorry for the frequent disturbance
Light should not dim when player lock has been applied

Screenshot_20240901-141841_mpvKt

Screenshot_20240901-141837_mpvKt

Screenshot_20240901-141828_mpvKt

Screenshot_20240901-141823_mpvKt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abdallahmehiz @Brajesh3