-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pigments don't update their geometry when font-related attributes change #51
Comments
Hmm, that's actually not true for font size and line height when modified from the settings, but it's true I don't listen to stylesheets changes. It shouldn't be too hard to fix. |
Actually I remember I've tested changing font attributes from settings as well just to check if there's a different behavior, but it seems I get the same results. The only way to heal it is to edit the line containing the color declaration, only then the pigments relocate. |
Are you sure about changing the settings not affecting the markers? Because as far as I can tell it works, and there's even tests for that: The tests: |
I've checked this usecase specifically then and the problem existed, but now it seems the pigments update when changing font attributes from settings, so it seems you're right on this one, my apologies. |
No pb, there's always some cases I didn't foresee that may not work, but if I've written tests for a given use case I'm generally pretty confident about them working properly. To being cautious I'll also add a listener to the stylesheets changes events in the next release. |
Sounds great! Really useful package btw! |
When changing the font family, font size, font height or any other attribute that causes the characters to shift, the pigments overlay do not update their position and size.
The text was updated successfully, but these errors were encountered: