Make TestOnPRs part of minimal template #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intrusive part of TestOnPRs is the ReusableTest, which is already added in the minimal. So we might as well benefit from it and have the improved PR testing. This removes the question and fix the files accordingly. Closes #312 Breaking change: Question SimplifiedPRTest is removed. If you chose recommended or explicitly answered it as true, nothing changes. If you chose minimum or explicitly answered it as false, you will have a new file .github/workflows/TestOnPRs.yml and your Test.yml will change. Pull Requests will run on a smaller matrix now. See the docs for more information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 57 57
=========================================
Hits 57 57 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intrusive part of TestOnPRs is the ReusableTest, which is already
added in the minimal. So we might as well benefit from it and have the
improved PR testing.
This removes the question and fix the files accordingly.
Closes #312
Breaking change: Question SimplifiedPRTest is removed. If you chose
recommended or explicitly answered it as true, nothing changes.
If you chose minimum or explicitly answered it as false, you will have a
new file .github/workflows/TestOnPRs.yml and your Test.yml will change.
Pull Requests will run on a smaller matrix now. See the docs for more
information.