Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show grade-up message for all applicable disciplines on race result dialog #41

Closed
abesto opened this issue Apr 29, 2022 · 1 comment
Closed

Show grade-up message for all applicable disciplines on race result dialog #41

abesto opened this issue Apr 29, 2022 · 1 comment
Labels
enhancement New feature or request wishlist

Comments

@abesto
Copy link
Owner

abesto commented Apr 29, 2022

Currently we only show a grade-up message for the discipline the race was run in. Due to cross-discipline XP gains, it's possible to grade up in multiple disciplines with a single race. Would be nice to show a message for each.

Code pointer: src/app/pages/MainPage/components/RaceResultFeedback.tsx
@abesto abesto added the enhancement New feature or request label Apr 29, 2022
@abesto abesto mentioned this issue Apr 29, 2022
Closed
@abesto
Copy link
Owner Author

abesto commented May 14, 2022 •
edited
Loading

Fixed by 9978766. That commit also puts in place the machinery needed to easily implement achievements (#22)

image

@abesto abesto closed this as completed May 14, 2022
@abesto abesto mentioned this issue May 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wishlist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abesto