Bug Fixes and Maintenance updates #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🧑💻 Renamed `operational_mode` metadata parameter to `ffdecoder_operational_mode`. - 🎨 Fixed redundant conditional logic.
- ✨ Added a new `source_audio_samplerate` metadata parameter. - 🏗️ Re-implemented `__extract_audio_bitrate` internal function from scratch as `__extract_audio_bitrate_nd_samplerate`. - ⚡️ Implemented new algorithm to extract both extract both audio bitrate and samplerate from given source. - 🔨 Updated regex patterns according to changes. - 🐛 Fixed forward slash bugs in regex patterns. - 🎨 Updated `__contains_video` and `__contains_audio` logic to support new changes. - 💥 Now any of both video bitrate or video framerate are sufficient to decide to if source has video stream. - 💥 Also, Now any of both audio bitrate or video samplerate are sufficient to decide to if source has audio stream. - 🐛 Fixed IndexError when no bitrate was discovered in given source. - 🎨 Updated indentation and code comments
- ✏️ Fixed content and typos. - 📝 Updated Roadmap.
- 🚧 Reflected recent changes in Sourcer and FFdecoder API's metadata. - 🎨 Updated sample code formatting from `sh` to `json`. - 📄 Fixed year in license notice. - 🎨 Fixed spacing.
- ✨ Added instructions to download `prepare_dataset.sh` using curl. - 📝 Updated dependencies for `pytest`. - 🐛 Fixed bugs in hyperlinks.
- 📝 Updated generating Video from Image sequence to save video using OpenCV writer instead of WriteGear API. - ✨ Added `frame_format="bgr24"`and additional instructions regarding OpenCV writer. - 📝 Updated example codes with new changes. - 🔥 Removed redundant code. - 🐛 Fixed missing `"-vcodec": "h264_cuvid"` value in example code. - 🎨 Rearranged examples placement.
… Deployer - 👷 Added Skip Duplicate Actions(`fkirc/skip-duplicate-actions@master`) Workflow to DeFFcode Docs Deployer to prevent redundant duplicate workflow-runs. - ✨ Added new `pre_job` job. - ⚗️ Added `release` to `do_not_skip`. - 🎨 Updated previous job to must require `pre_job` to be executed in advance and `needs.pre_job.outputs.should_skip != 'true'` to be true.
abhiTronix
added
Bug 🐞
- 🎨 Re-implemented `fkirc/skip-duplicate-actions@master` to Skip individual deploy steps instead of Skip entire jobs - 🔥 Removed redundant code and definitions.
abhiTronix
added
Bug Fix 🐛 💣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
This PR is aimed at providing bug-fixes and maintenance updates for DeFFcode APIs, CI and docs.
Requirements / Checklist
Context
This PR will bring much needed bug-fixes and maintenance updates for smooth and stable working of DeFFcode APIs, CI and docs.
Types of changes
Miscellaneous (if available):