Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkboxes are unresponsive #39

Closed
hugo-azevedo opened this issue Aug 21, 2015 · 8 comments
Closed

Checkboxes are unresponsive #39

hugo-azevedo opened this issue Aug 21, 2015 · 8 comments

Comments

@hugo-azevedo
Copy link

Hi, there!
Thanks for ng-joyride! I'm loving using it, but I'm afraid I have found another issue for which I would be grateful for any help.

Issue: Checkboxes during a tour fail to register a value change regardless of the click actually being detected (the checkbox flickers a darker grey).

Here's a plunker that reproduces the issue:
http://plnkr.co/8xsZvrhEAKaIJoJVphCj

Many thanks!

@abhikmitra
Copy link
Owner

This is by design. Generally when the popover is on , you don't want the user to trigger something else by clicking. In case you are looking to forward the joyride by clicking on the checkbox , add an advanceOn

@hugo-azevedo
Copy link
Author

I see. I'm using joyRide for walkthrough (hold-user's-hand-guides) that get the user clicking the through correct process and get the outcome they desire at the end.

Thanks

@hugo-azevedo
Copy link
Author

In my case, there are actually a whole bunch of checkboxes that the user might or might not want to toggle, so an advanceOn doesn't really work, cos as far as I know you can only set 1 advanceOn per element, correct?

Would it be feasible to introduce a config boolean to switch this off?

Many thanks!

@abhikmitra
Copy link
Owner

Ok. will add a flag and check for it in preventDefault

@hugo-azevedo
Copy link
Author

Fantastic! Thank you very much!

@abhikmitra
Copy link
Owner

Use the flag shouldNotStopEvent . Checks the docs for more info.

@hugo-azevedo
Copy link
Author

Fantastic! Will test it now. Thanks!

@hugo-azevedo
Copy link
Author

Works a treat! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants