Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate failures in test case RealtimeClientPresenceTests test__078__Presence__enter__optional_data_can_be_included_when_entering_a_channel (1e5beffd-b21f-4281-85c9-b1b6ab02471d) #1331

Closed
lawrence-forooghian opened this issue Apr 7, 2022 · 0 comments
Closed

Investigate failures in test case RealtimeClientPresenceTests test__078__Presence__enter__optional_data_can_be_included_when_entering_a_channel (1e5beffd-b21f-4281-85c9-b1b6ab02471d) #1331

lawrence-forooghian opened this issue Apr 7, 2022 · 0 comments
Assignees
@lawrence-forooghian
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 7, 2022 •
edited by sync-by-unito bot
Loading

https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/1e5beffd-b21f-4281-85c9-b1b6ab02471d

RealtimeClientPresenceTests.test__078__Presence__enter__optional_data_can_be_included_when_entering_a_channel

Split from #1330.

┆Issue is synchronized with this Jira Bug by Unito
@lawrence-forooghian lawrence-forooghian added failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. test-stability labels Apr 7, 2022
@lawrence-forooghian lawrence-forooghian mentioned this issue Apr 7, 2022
Open
@lawrence-forooghian lawrence-forooghian self-assigned this Apr 7, 2022
This was referenced Apr 11, 2022
Closed
Closed
Closed
Closed
This was referenced May 3, 2022
Closed
Closed
lawrence-forooghian added a commit that referenced this issue May 4, 2022
@lawrence-forooghian
Fix test case RealtimeClientPresenceTests.test__078__Presence__enter_…
2b07a94 
…_optional_data_can_be_included_when_entering_a_channel

This fixes the error

> Waited more than 20.0 seconds
> (/Users/runner/work/ably-cocoa/ably-cocoa/Spec/Tests/RealtimeClientPresenceTests.swift#CharacterRangeLen=0&EndingLineNumber=2443&StartingLineNumber=2443)

I’m speculating that this failure is caused by the same thing as in
d969acc and 3f155f9 (it is certainly vulnerable to the same problem),
and hence am attempting the same fix.

Test case:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/1e5beffd-b21f-4281-85c9-b1b6ab02471d

Example failure:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/failures/d34e5c73-63d4-4aa2-ab1b-201e0b453ee7

Closes #1331.
@lawrence-forooghian lawrence-forooghian mentioned this issue May 5, 2022
Merged
lawrence-forooghian added a commit that referenced this issue May 8, 2022
@lawrence-forooghian
Merge pull request #1391 from ably/1309-1321-1331-1333-presence-test-…
d85bd9f 
…fixes

(#1309, #1321, #1331, #1333) Fixes for 4 presence tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian