Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate failures in test case RealtimeClientPresenceTests test__037__Presence__update__should_update_the_data_for_the_present_member_with_a_value (114e01a8-8971-4c3a-9cb7-0bb128e2749e) #1309

Closed
lawrence-forooghian opened this issue Mar 14, 2022 · 0 comments
Assignees
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Mar 14, 2022

https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/114e01a8-8971-4c3a-9cb7-0bb128e2749e

RealtimeClientPresenceTests.test__037__Presence__update__should_update_the_data_for_the_present_member_with_a_value()

Split from #1279. Our first investigation of a failure.

┆Issue is synchronized with this Jira Bug by Unito

@lawrence-forooghian lawrence-forooghian self-assigned this Mar 14, 2022
@lawrence-forooghian lawrence-forooghian changed the title Investigate failures in test case RealtimeClientPresenceTests.test__037__Presence__update__should_update_the_data_for_the_present_member_with_a_value() 114e01a8-8971-4c3a-9cb7-0bb128e2749e Investigate failures in test case 114e01a8-8971-4c3a-9cb7-0bb128e2749e Mar 14, 2022
@ably-sync-bot ably-sync-bot changed the title Investigate failures in test case 114e01a8-8971-4c3a-9cb7-0bb128e2749e Investigate failures in test case RealtimeClientPresenceTests test__037__Presence__update__should_update_the_data_for_the_present_member_with_a_value (114e01a8-8971-4c3a-9cb7-0bb128e2749e) Apr 4, 2022
@lawrence-forooghian lawrence-forooghian added failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. test-stability labels Apr 7, 2022
lawrence-forooghian added a commit that referenced this issue May 4, 2022
…__should_update_the_data_for_the_present_member_with_a_value

This fixes the error

> Waited more than 20.0 seconds
> (/Users/runner/work/ably-cocoa/ably-cocoa/Spec/Tests/RealtimeClientPresenceTests.swift#CharacterRangeLen=0&EndingLineNumber=1183&StartingLineNumber=1183)

This happens because, depending on timing, the ENTER presence action
that we publish (more or less simultaneously with attaching to the
channel) will sometimes be reflected by Realtime in the channel’s
initial post-attach SYNC.

In this case, the SDK will ignore any subsequent matching ENTER messages
that it receives and will not send them to subscribers, causing the
aforementioned timeout.

So, we avoid this scenario by waiting for any post-attach SYNC to
complete before publishing the ENTER presence action.

Test case:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/114e01a8-8971-4c3a-9cb7-0bb128e2749e

Example failure:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/failures/48dce95a-dca8-4b3c-952d-865277d63b73

Closes #1309.
lawrence-forooghian added a commit that referenced this issue May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Development

Successfully merging a pull request may close this issue.

1 participant