Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate failures in test case RealtimeClientPresenceTests test__015__Presence__subscribe__with_no_arguments_should_subscribe_a_listener_to_all_presence_messages (84c9fbc5-8882-4010-ba99-3e44d1793397) #1321

Closed
lawrence-forooghian opened this issue Apr 4, 2022 · 0 comments
Closed

Investigate failures in test case RealtimeClientPresenceTests test__015__Presence__subscribe__with_no_arguments_should_subscribe_a_listener_to_all_presence_messages (84c9fbc5-8882-4010-ba99-3e44d1793397) #1321

lawrence-forooghian opened this issue Apr 4, 2022 · 0 comments
Assignees
@lawrence-forooghian
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 4, 2022 •
edited by sync-by-unito bot
Loading

https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/84c9fbc5-8882-4010-ba99-3e44d1793397

RealtimeClientPresenceTests.test__015__Presence__subscribe__with_no_arguments_should_subscribe_a_listener_to_all_presence_messages

Split from #1279. Our second investigation of a failure.

┆Issue is synchronized with this Jira Bug by Unito
@lawrence-forooghian lawrence-forooghian mentioned this issue Apr 4, 2022
Closed
@lawrence-forooghian lawrence-forooghian added test-stability failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. labels Apr 7, 2022
This was referenced Apr 7, 2022
Open
Closed
This was referenced May 3, 2022
Closed
Closed
lawrence-forooghian added a commit that referenced this issue May 4, 2022
@lawrence-forooghian
Fix test case RealtimeClientPresenceTests.test__015__Presence__subscr…
fab7b3e 
…ibe__with_no_arguments_should_subscribe_a_listener_to_all_presence_messages

This fixes the error

> expected to equal <Enter>, got <Present>
> (/Users/runner/work/ably-cocoa/ably-cocoa/Spec/Tests/RealtimeClientPresenceTests.swift#CharacterRangeLen=0&EndingLineNumber=535&StartingLineNumber=535)

The cause for this problem is the same as that fixed in d969acc, and we
fix it the same way.

Test case:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/test_cases/84c9fbc5-8882-4010-ba99-3e44d1793397

Example failure:
https://test-observability.herokuapp.com/repos/ably/ably-cocoa/failures/741b646b-e921-479f-82e6-cbd0a9148a5a

Closes #1321.
@lawrence-forooghian lawrence-forooghian mentioned this issue May 5, 2022
Merged
lawrence-forooghian added a commit that referenced this issue May 8, 2022
@lawrence-forooghian
Merge pull request #1391 from ably/1309-1321-1331-1333-presence-test-…
d85bd9f 
…fixes

(#1309, #1321, #1331, #1333) Fixes for 4 presence tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lawrence-forooghian