Symmetric encryption #192
Merged
Symmetric encryption #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into bug/channel-options # Conflicts: # lib/src/platform/src/codec.dart # lib/src/platform/src/realtime/realtime_channel.dart
- Handle setting ARTChannelOptions callback correctly, instead of crashing on iOS - Encode and decode CipherParams if used on both Android and iOS - Fix mistaken string constant usage (PlatformMethod.setRealtimeChannelOptions instead of Rest)
Temporarily remove cipher related code, to be re-added in a separate PR 4e54081 Ben Butterworth <24711048+ben-xD@users.noreply.github.com> 27 Oct 2021 at 22:14
This reverts commit fe83147.
…/symmetric-encryption # Conflicts: # lib/src/platform/src/rest/rest_channel.dart # lib/src/realtime/src/realtime_channel_options.dart # lib/src/realtime/src/realtime_channels_interface.dart # lib/src/rest/src/rest_channel_options.dart
ben-xD
changed the base branch from
main
to
bug/fix-runtime-crash-for-channel-options
Base automatically changed from
bug/fix-runtime-crash-for-channel-options
to
main
November 2, 2021 07:28
…rams` method overloads in Crypto.java for base64 encoded (String)
- Put encoding/decoding in the right place on all 3 platforms (A/I/D) - Remove cipherParamsStorage, opting to pass all data back to Dart side for iOS devices. Android devices still have handles
Co-authored-by: Lewis Marshall <lewis.marshall@ably.com>
lmars
approved these changes
Nov 9, 2021
… into feature/symmetric-encryption # Conflicts: # example/pubspec.lock # example/pubspec.yaml
tiholic
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #104
It adds symmetric encryption, please read the new documentation added to the README.
This PR will not yet work on iOS because it does not yet use the bug fix from Ably Cocoa: ably/ably-cocoa#1208 (I've tested this locally). A new version of Ably Cocoa needs to be released, and then Ably Flutter upgraded to the latest version (Ably Cocoa has a couple of small breaking changes fixable in less than 1 minute). I have confirmed that it works in Ably Flutter with this bug fix.
This PR does not yet include decryption of messages which are passed to
PresenceMessage.fromEncodedandMessage.fromEncoded, as per TP4 and TM3. This will be done in a separate PR #207, to keep this PR smaller.