Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symmetric encryption #192

Merged
merged 62 commits into from Nov 10, 2021
Merged

Symmetric encryption #192

merged 62 commits into from Nov 10, 2021

Commits on Oct 6, 2021

  1. Refactor classes into separate files

    @ben-xD
    ben-xD committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    d02a652 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2021

  1. Merge remote-tracking branch 'origin/feature/push-notifications-dart'… 

    … into bug/channel-options

# Conflicts:
#	lib/src/platform/src/codec.dart
#	lib/src/platform/src/realtime/realtime_channel.dart
    @ben-xD
    ben-xD committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    caab4d2 View commit details
    Browse the repository at this point in the history

  2. Add CipherParams parameters and deserialize it correctly

    @ben-xD
    ben-xD committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    67acb68 View commit details
    Browse the repository at this point in the history

  3. - Decode and use mode from ChannelOptions on Android 

    - Handle setting ARTChannelOptions callback correctly, instead of crashing on iOS
- Encode and decode CipherParams if used on both Android and iOS
- Fix mistaken string constant usage (PlatformMethod.setRealtimeChannelOptions instead of Rest)
    @ben-xD
    ben-xD committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    d9c4a3d View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Temporarily remove cipher related code, to be re-added in a separate PR

    @ben-xD
    ben-xD committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    4e54081 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into bug/channel-options

    @ben-xD
    ben-xD committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    28080bf View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Continuating of recent commit: 4e54081 

    Temporarily remove cipher related code, to be re-added in a separate PR	4e54081	Ben Butterworth <24711048+ben-xD@users.noreply.github.com> 	27 Oct 2021 at 22:14
    @ben-xD
    ben-xD committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    fe83147 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Remove unnecessary code change

    @ben-xD
    ben-xD committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    4072c44 View commit details
    Browse the repository at this point in the history

  2. Revert "Continuating of recent commit: 4e54081" 

    This reverts commit fe83147.
    @ben-xD
    ben-xD committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    8d6a36a View commit details
    Browse the repository at this point in the history

  3. Read cipher from channel options in native side

    @ben-xD
    ben-xD committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    33e26b1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bug/fix-runtime-crash-for-channel-options' into feature… 

    …/symmetric-encryption

# Conflicts:
#	lib/src/platform/src/rest/rest_channel.dart
#	lib/src/realtime/src/realtime_channel_options.dart
#	lib/src/realtime/src/realtime_channels_interface.dart
#	lib/src/rest/src/rest_channel_options.dart
    @ben-xD
    ben-xD committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    f8e3346 View commit details
    Browse the repository at this point in the history

  5. WIP

    @ben-xD
    ben-xD committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    69db673 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Complete symmetric encryption on Android

    @ben-xD
    ben-xD committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    50887f3 View commit details
    Browse the repository at this point in the history

  2. WIP: Symmetric encryption on iOS

    @ben-xD
    ben-xD committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    ddf01f9 View commit details
    Browse the repository at this point in the history

  3. Manually decode base64 on Android platform to overcome missing `getPa… 

    …rams` method overloads in Crypto.java for base64 encoded (String)
    @ben-xD
    ben-xD committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    426baca View commit details
    Browse the repository at this point in the history

  4. Require key to be non-null in interface

    @ben-xD
    ben-xD committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    6c44ad7 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Merge remote-tracking branch 'origin/main' into feature/symmetric-enc… 

    …ryption
    @ben-xD
    ben-xD committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    2893d70 View commit details
    Browse the repository at this point in the history

  2. Add generateRandomKey method on both iOS and Android

    @ben-xD
    ben-xD committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a6b5d73 View commit details
    Browse the repository at this point in the history

  3. Revert changes to AblyFlutterReader

    @ben-xD
    ben-xD committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    b282d05 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Implement and validate Android encryption works 

    - Put encoding/decoding in the right place on all 3 platforms (A/I/D)
- Remove cipherParamsStorage, opting to pass all data back to Dart side for iOS devices. Android devices still have handles
    @ben-xD
    ben-xD committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    084a2be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'refactor/simplify-main-state' into feature/symmetric-en… 

    …cryption
    @ben-xD
    ben-xD committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    74cf012 View commit details
    Browse the repository at this point in the history

  3. Use EncryptedMessageService in example app correctly

    @ben-xD
    ben-xD committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4a868f3 View commit details
    Browse the repository at this point in the history

  4. Add Publish encrypted messages with rest on example app

    @ben-xD
    ben-xD committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    30cecd7 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2021

  1. Call connect only if not connected already 

    Remove unused code
    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    d597a4c View commit details
    Browse the repository at this point in the history

  2. Run flutter format .

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dc26813 View commit details
    Browse the repository at this point in the history

  3. Android: Add more documentation to CipherParamsStorage

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    497067f View commit details
    Browse the repository at this point in the history

  4. iOS: Remove unused code

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    4a8b38c View commit details
    Browse the repository at this point in the history

  5. Formatting: Remove unused code, fix import style

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    13f8b9d View commit details
    Browse the repository at this point in the history

  6. Remove duplicate class

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    84ce348 View commit details
    Browse the repository at this point in the history

  7. Validate messages can be successfully encrypted and decrypted between… 

    … iOS and Android
    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    dbe5f7e View commit details
    Browse the repository at this point in the history

  8. Update comment

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    28f2996 View commit details
    Browse the repository at this point in the history

  9. Remove unused code, fix state in example app encrypted messages UI, a… 

    …dd documentation
    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    81426f5 View commit details
    Browse the repository at this point in the history

  10. Run flutter format .

    @ben-xD
    ben-xD committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    06fe63b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Add readme documentation for message encryption

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    afe25d5 View commit details
    Browse the repository at this point in the history

  2. Remove warning: symmetric encryption is not support

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    6cd1382 View commit details
    Browse the repository at this point in the history

  3. Simplification: replace 2 platform methods with usage of 1 existing p… 

    …latform method

And also add documentation
    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    fc50251 View commit details
    Browse the repository at this point in the history

  4. Add additional docs to symmetric encryption

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    5bac6af View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/refactor/class-move' into featur… 

    …e/symmetric-encryption
    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    0898c07 View commit details
    Browse the repository at this point in the history

  6. Fix failing test by importing and improve documentation minimally

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    73786b0 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into feature/symmetric-encryption

    @QuintinWillison
    QuintinWillison committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    e5c372e View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Improve documentation formatting and language

Co-authored-by: Quintin Willison <q@qwuk.net>
    @ben-xD @QuintinWillison
    ben-xD and QuintinWillison committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    127856d View commit details
    Browse the repository at this point in the history

  9. Remove extra forward slash in doc

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    9b42541 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary blank line

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    fb9cb6a View commit details
    Browse the repository at this point in the history

  11. "Dart-side" → "Dart side" and fix language

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    3c13d0f View commit details
    Browse the repository at this point in the history

  12. Improve docs language

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    68bb531 View commit details
    Browse the repository at this point in the history

  13. Finish Javadoc comment on CIpherParamsStorage

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    c08f148 View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review 

    Co-authored-by: Quintin Willison <q@qwuk.net>
    @ben-xD @QuintinWillison
    ben-xD and QuintinWillison committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    def6c2d View commit details
    Browse the repository at this point in the history

  15. Move isolated bullet points into previous bullet points

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    3faa10d View commit details
    Browse the repository at this point in the history

  16. Remove unused code. This code stopped being used in fc50251

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    8ecfce0 View commit details
    Browse the repository at this point in the history

  17. Replace bullet points with numbers

    @ben-xD
    ben-xD committed Nov 8, 2021
    Configuration menu
    Copy the full SHA
    61718ae View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Add warning about hashing a password to get a key, and more documenta… 

    …tion to encryption
    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    2b6e91b View commit details
    Browse the repository at this point in the history

  2. Assert length of key is 256 bits

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    a6ac0c3 View commit details
    Browse the repository at this point in the history

  3. Update README.md language 

    Co-authored-by: Lewis Marshall <lewis.marshall@ably.com>
    @ben-xD @lmars
    ben-xD and lmars committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    7288f1b View commit details
    Browse the repository at this point in the history

  4. Formatting (use ' instead of ")

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    e20a14d View commit details
    Browse the repository at this point in the history

  5. Remove key creation guidance / extra detail

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    bba9f4c View commit details
    Browse the repository at this point in the history

  6. Add support for 128 bit keys in symmetric encryption

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    0acd964 View commit details
    Browse the repository at this point in the history

  7. Improve UI appearance (bolding, capitalization)

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    5106a99 View commit details
    Browse the repository at this point in the history

  8. Remove outdated comment

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    9534782 View commit details
    Browse the repository at this point in the history

  9. Fix key length check (it was counting in bits, not bytes)

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    7bfb9a7 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/enhancement/update-dependencies'… 

    … into feature/symmetric-encryption

# Conflicts:
#	example/pubspec.lock
#	example/pubspec.yaml
    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    d64a097 View commit details
    Browse the repository at this point in the history

  11. Run flutter pub get

    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    3ac1957 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'enhancement/update-dependencies' into feature/symmetric… 

    …-encryption
    @ben-xD
    ben-xD committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    457e594 View commit details
    Browse the repository at this point in the history