Simplify state in example app #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reate them automatically at launch
ikbalkaya
approved these changes
Nov 4, 2021
QuintinWillison
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
I'm on the fence as to whether I'm truly in favour of this change, as the example app was originally designed to be very manually driven, which can be helpful when debugging as-yet-unidentified issues.
Given I know that we have reasons that we're pressured to deliver #192, and this PR is now blocking that, I guess we need to land this. But I would like to revisit this so I shall create an issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, users of the example app no longer need to create instances of Realtime and Rest. These get created automatically. This simplifies the state for the entire app, as the rest of the app can rely on Realtime and Rest instances existing. This allows me to avoid adding more complicated state management tools, like Bloc, getx, provider, etc for my upcoming symmetric encryption PR.
The UI changes from (before, left) and after (right):
