Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageExtras asJsonObject() should return a copy #583

Open
QuintinWillison opened this issue Jun 15, 2020 · 0 comments
Open

MessageExtras asJsonObject() should return a copy #583

QuintinWillison opened this issue Jun 15, 2020 · 0 comments
Labels
enhancement New feature or improved functionality.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Jun 15, 2020 •
edited by sync-by-unito bot
Loading

JsonObject instances are mutable. See this review comment.

I didn't want to knee jerk make this change without due consideration at the point of releasing 1.2.1 so this needs careful consideration as there may be other areas in the codebase where we're using Gson in a similar manner and should be addressing this concern.

┆Issue is synchronized with this Jira Task by Unito
@ttypic ttypic added the enhancement New feature or improved functionality. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuintinWillison @ttypic