Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS lambda packaging #97

Closed
SimonWoolf opened this issue Dec 1, 2017 · 9 comments
Closed

AWS lambda packaging #97

SimonWoolf opened this issue Dec 1, 2017 · 9 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@SimonWoolf
Copy link
Member

SimonWoolf commented Dec 1, 2017

Customer states that when they try to run a python program packaged for aws lambda that uses ably, they get a "cannot import name '_AES'" error, though it works fine when run locally. They're not using crypto features, and are using the default package (from pip install ably), which doesn't include crypto. Customer states they are using python 3.6, but declines to provide any more details or steps to reproduce their issue.

@mattheworiordan mattheworiordan added the bug Something isn't working. It's clear that this does need to be fixed. label Dec 1, 2017
@mattheworiordan
Copy link
Member

@jdavid would be good to address this too if you can?

@jdavid
Copy link
Contributor

jdavid commented Dec 12, 2017

Actually the version that makes crypto optional (commit 2f7e0d3) has not been released yet. A new release should fix it; but maybe merge #98 first?

@mattheworiordan
Copy link
Member

@jdavid I wanted to, but you've not responded to my question re: failures

@jdavid
Copy link
Contributor

jdavid commented Dec 12, 2017

I have answered in #88 where a similar question/comment has been posted. The failures don't seem related to crypto. Hopefully the errors will be fixed this afternoon.

@mattheworiordan
Copy link
Member

Ok, thanks @jdavid. Shout if you need me to merge #98 now or not.

@jdavid
Copy link
Contributor

jdavid commented Dec 13, 2017

PR #98 can be merged already.

@mattheworiordan
Copy link
Member

Is this now resolved @jdavid?

@jdavid
Copy link
Contributor

jdavid commented Dec 26, 2017

Yes. Should the customer validate?

@jdavid
Copy link
Contributor

jdavid commented Feb 15, 2018

I think we can close this, should be good with the 1.0.1 release

@jdavid jdavid closed this as completed Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Development

No branches or pull requests

3 participants