Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod name is too generic #8

Closed
QuintinWillison opened this issue Mar 11, 2020 · 3 comments
Closed

Pod name is too generic #8

QuintinWillison opened this issue Mar 11, 2020 · 3 comments
Assignees
@ricardopereira

Comments

@QuintinWillison
Copy link
Contributor

Currently DeltaCodec - could you please rename to AblyDeltaCodec.

My belief is that your procedure will be to:

  1. Rename it in the spec in this codebase.
  2. Push it to trunk as a new pod - please also add me as an owner while you're there.
  3. Deprecate the old pod.

Thanks!
@QuintinWillison QuintinWillison mentioned this issue Mar 11, 2020
Merged
@ricardopereira
Copy link
Contributor

@QuintinWillison Should I change the project name and module name too (AblyDeltaCodec.framework instead of DeltaCodec.framework)?

@QuintinWillison
Copy link
Contributor Author

Yes, please. Thanks!

@ricardopereira ricardopereira mentioned this issue Apr 10, 2020
Merged
@ricardopereira
Copy link
Contributor

Done 😊

https://cocoapods.org/pods/DeltaCodec
Screenshot 2020-04-10 at 11 43 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardopereira ricardopereira

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricardopereira @QuintinWillison