Slightly different use of faces in the overlays

[ilohmar]

I really like avy so far, to replace the rather inflexible ace-jump-mode setup I had. However, there is one thing that strikes me as odd about the use of the three faces avy-lead-face*: avy-lead-face-0 is used for the 1st non-terminating lead char, not for all the chars I can select at any given time.

So in a tree with 2- and 3-char possibilities, after I have typed the 1st char, the 2nd char in the 3-char sequences is highlighted with avy-lead-face-0, but the 2nd char in the 2-char sequences is highlighted "normally" with avy-lead-face (because it is terminating the sequence).

To me, that does not make much sense; I would always like all possible choices to stand out. Could you explain the rationale behind the current behavior? It seems this could be changed (even optionally) in the avy--overlay-* functions, what do you think about that? If you agree, I would get to that soon.

[abo-abo]

You know that you can customize faces, right? M-x customize-group avy. Make all the faces the same if you like.

[ilohmar]

Yes, I do know :) If I make them the same, the issue does not exist, of course. It exists because I want them to be different: I want the leading chars that I can choose to stand out, but always, not only if they are "non-terminating"...

[ilohmar]

Thanks a lot! That seems to do exactly what I had in mind, at least for the styles pre and at-full.

I do not use the at style myself. You might want to consider to use avy-lead-face-0 in that case as well iff avy-highlight-first is non-nil. It does not affect me, but seems to me to be the most consistent behavior (also given the docstring of the new option).

Thanks again, I'm gonna replace some more functionality with avy now :)