tramp and counsel-find-file hangs with 'Blocking call to accept-process-output with quit inhibited!!'

[Jehops]

Hello,

To reproduce the issue, I cloned the repository and did counsel-find-file. When the supplied path is of the form ssh:host:/dir1/dir2..., when changing directories (enter /), there is usually a short hang and Blocking call to accept-process-output with quit inhibited!! is reported in the minibuffer. There is a caveat; this is with master-branch Emacs (94245b9 from 2019-02-01).

Regards,

Joseph

[Jehops]

Update: I submitted an Emacs bug, since it's unclear (to me) where the source of the problem is.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34297

[basil-conto]

I too see this message. I assume it was uncovered by recent changes to Tramp in this area; see the following emacs-devel thread: https://lists.gnu.org/archive/html/emacs-devel/2019-01/msg00301.html.

The warning itself was first added in Emacs 24.1: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2b0a91e78f83fb446cc38efb99399e83ad2cded3

(wait_reading_process_output): Output a warning when called in such a way that it could block without being interruptible.

Hopefully Michael Albinus, Paul Eggert, or Stefan Monnier will have some insights into why this warning is being triggered and how to avoid it.

Note that there is also some further fallout from the recent changes: https://lists.gnu.org/archive/html/emacs-devel/2019-01/msg00747.html

My guess is that this issue is not Counsel's fault, and the best it can do is either wait for it to be fixed upstream (preferable), or try to inhibit the echoing of this warning (not a particularly good idea).

[basil-conto]

Aaand Michael's latest commit seems to have fixed the issue for me: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b32ac17c32486d8fce0fb9ecd5e09fe324448d3d

@Jehops do you still run into the warning with latest master?

[basil-conto]

Hm, reverting that commit doesn't reintroduce the warning for me, so I don't know what made it go away.

[Jehops]

I can confirm that updating to b32ac17 stops the hangs/warnings here as well.

[basil-conto]

Thanks for reporting back. Can this issue be closed then?

[Jehops]

I think so. Thank you for your feedback. If I hear something worth reporting here, I will do so.

[basil-conto]

Thanks, please do.