-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any thought given to dependency injection for Redis client? #3
Comments
I've modified your library a little to use gopkg.in/redis.v5 here, and I'd love any feedback you have. It doesn't do dependency injection for the Redis client as I suggested above. |
Thanks for suggestion, dependency injection looks like a good idea. |
Granted, dependency injection might be tricky unless the user's Redis client of choice implements all Redis commands properly that you utilize in this library. I'm happy to maintain my copy and I'll set a watch on your repo to see if new code gets merged in to apply bug fixes on my side as well. |
I just added the Buckets interface which is the backend of rerate, so we can using builtin RedigoBuckets/RedisV5Buckets or building a custom Buckets( MySQLBuckets, InMEMBuckets, etc.) |
We really like your library but our project is already using gopkg.in/redis.v5 and it feels odd to use a different Redis client library (which maintains its own connection to Redis) when we'd like to just use the client we've got elsewhere.
Any plans for dependency injection in this regard?
The text was updated successfully, but these errors were encountered: