Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest Rust data through Github api #1427

Merged

Conversation

shravankshenoy
Copy link
Contributor

@shravankshenoy shravankshenoy commented Feb 28, 2024

Fixes #1039

Changes Made

Modified github.py importer to ingest Rust data and added test files

Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>
Signed-off-by: Shenoy <shravanshenoy1998@hotmail.com>
@shravankshenoy
Copy link
Contributor Author

Somehow, just after making this PR, I came across this PR in univers : aboutcode-org/univers#84. I am not exactly sure if this PR depends on that, but incase it does, we could probably put review of this PR on hold until that is completed.

@TG1999 TG1999 requested a review from ziadhany July 9, 2024 15:36
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999 TG1999 merged commit d7b66fb into aboutcode-org:main Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingest github ecosystems
2 participants