You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AbpCrudPageBase (in the development branch) for BlazoriseUI uses the same "SavedSuccessfully" localization resource to notify successful entity creations or updates.
I think it's a mistake and should use different resources: "SavedSuccessfully" in OnCreatedEntityAsync and "UpdatedSuccessfully" in OnUpdatedEntityAsync.
In addition, It seems the method GetDeleteConfirmationMessage is not being used. I guess the purpose is to show a confirmation message before deleting an entity, which is a very common feature.
Finally, instead of calling await Notify.Success(L["SavedSuccessfully"]); or await Notify.Success(L["UpdatedSuccessfully"]); I would suggest to use a method that can be overridden to get the message, like GetSavedSuccessfullyMessage() and GetUpdatedSuccessfullyMessage(). In that way only this method needs to be overridden to change the default message.
Reproduction Steps
Create a Blazor Server web project with ABP 8.2.0-rc.5
When creating and updating entities using AbpCrudPageBase methods, the same message is received regardless it's a creation or an update.
Expected behavior
Display different successful messages for creating and updating entities
Actual behavior
When creating and updating entities using AbpCrudPageBase methods, the same message is received regardless it's a creation or an update.
Regression?
No response
Known Workarounds
No response
Version
8.2.0-rc.5
User Interface
Blazor Server
Database Provider
EF Core (Default)
Tiered or separate authentication server
None (Default)
Operation System
Windows (Default)
Other information
No response
The text was updated successfully, but these errors were encountered:
Is there an existing issue for this?
Description
AbpCrudPageBase (in the development branch) for BlazoriseUI uses the same "SavedSuccessfully" localization resource to notify successful entity creations or updates.
I think it's a mistake and should use different resources: "SavedSuccessfully" in OnCreatedEntityAsync and "UpdatedSuccessfully" in OnUpdatedEntityAsync.
In addition, It seems the method GetDeleteConfirmationMessage is not being used. I guess the purpose is to show a confirmation message before deleting an entity, which is a very common feature.
Finally, instead of calling
await Notify.Success(L["SavedSuccessfully"]);
orawait Notify.Success(L["UpdatedSuccessfully"]);
I would suggest to use a method that can be overridden to get the message, likeGetSavedSuccessfullyMessage()
andGetUpdatedSuccessfullyMessage()
. In that way only this method needs to be overridden to change the default message.Reproduction Steps
Expected behavior
Display different successful messages for creating and updating entities
Actual behavior
When creating and updating entities using AbpCrudPageBase methods, the same message is received regardless it's a creation or an update.
Regression?
No response
Known Workarounds
No response
Version
8.2.0-rc.5
User Interface
Blazor Server
Database Provider
EF Core (Default)
Tiered or separate authentication server
None (Default)
Operation System
Windows (Default)
Other information
No response
The text was updated successfully, but these errors were encountered: