Sync with shared folders/drives for onedrive business #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'drive_id' parameter. If this parameter is given, the driveUrl is modified so all requests will go to the specified driveId in stead of the users drive. The file README.odrive.md shows, how to get the driveId of a Sharepoint group. We removed unused code which could create problems with future additions. The variable itemByIdUrl is prefixed for the personal OneDrive drive. However it is never used in the code. The itemByIdUrl is constructed on the fly where needed. The variable itemByPathUrl ditto, however is used in viewChangesByPath(), a function which in turn is never used in the code. The function seems also to calculate the resulting path url incorrectly. All three are removed, so if somebody wants to implement itemByPath functionality in the future she does not stumble over hardcoded paths which would have to be fixed if used on a none personal drive.
|
Thanks for this. Will go over this, as I had some other idea's on how to get this solved, as there could be numerous business shared folders that you 'may' want to be syncing with. Regarding the quota check - it potentially is '0' due to the changing driveId. Will have to see how I can create shared folders using the OneDrive Business Developers account so that I can test / work on this in due time. |
|
This gets the job done for me. I'll report back if I run into any issues. |
|
Updated to master in PR #206 Closing this PR |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm actively using this branch since a few days to sync my organizations shared onedrive-folders with my local machine. This is a rebase of skilion/onedrive#302 onto current head.
Only culprit currently: Onedrive API reports '0' for all quotas, even if I'm able to upload stuff. I've overridden the quota checks and stuff will successfully get uploaded. I couldn't find any information how a zero quota should be interpreted (maybe it means unlimited?) or if/how it is reported for shared drives. Any ideas on that one?
No real work done by me here, all credits back to @jorge-leon.