Shutdown Inotify Monitor Gracefully

[JC-comp]

This pull request adds functionality to gracefully shut down the inotify monitor when the user sends a SIGINT signal (Ctrl+C). When the monitor receives the SIGINT signal, it closes the inotify file descriptor and exits the program gracefully.

Changes

• Add interrupt mechanism to monitor worker
• Add shutdown process for Monitor
• Improve communication between monitor worker

[abraunegg]

@JC-comp
This PR does not compile cleanly:

ldc2  -w -g -O -J. -d-debug -gc -L-lcurl -L-lsqlite3  -L-ldl src/main.d src/config.d src/log.d src/util.d src/qxor.d src/curlEngine.d src/onedrive.d src/sync.d src/itemdb.d src/sqlite.d src/clientSideFiltering.d src/monitor.d src/arsd/cgi.d -ofonedrive
onedrive.o:cgi.d:function _D7monitor23MonitorBackgroundWorker11__fieldDtorMFNeZv: error: undefined reference to '_D3std7process4Pipe11__fieldDtorMOFNeZv'
collect2: error: ld returned 1 exit status

[JC-comp]

@abraunegg
I am unable to reproduce this issue on my end. Could you please test it in a new environment or provide detailed setup instructions for your environment?

$ git clone https://github.com/abraunegg/onedrive
$ git fetch origin pull/2628/head:pr2628
$ git switch pr2628
$ source ~/dlang/ldc-1.36.0/activate
$ ./configure
$ make
if [ -f .git/HEAD ] ; then \
        git describe --tags > version ; \
else \
        echo v2.5.0-alpha-5 > version ; \
fi
ldc2 -w -g -O -J. -L-lcurl -L-lsqlite3  -L-ldl src/main.d src/config.d src/log.d src/util.d src/qxor.d src/curlEngine.d src/onedrive.d src/sync.d src/itemdb.d src/sqlite.d src/clientSideFiltering.d src/monitor.d src/arsd/cgi.d -ofonedrive
$ 

---

Update
I'm unsure of the root cause of the issue or if any elements are missing. However, I can confirm successful compilation with ldc version 1.30.0 in my environment.

[abraunegg]

@JC-comp
Unfortunately using a more modern LDC compiler is not going to be possible ... why?

The issue stems from Debian and Ubuntu LTS versions - such as Ubuntu 20.04. It's ldc package is only v1.20.1 , thus, this is the minimum version that all compilation needs to be tested against. Why?

Because the distribution version of 'ldc' is used to compile the packages presented at OpenSuSE Build Service

This means, the minimum version of LDC that can be tested against against all of these, which right now is Ubuntu 20.04 which is LDC v1.20.1.

Currently I test against an even lower version (v1.18.0) because of even older architectures for Raspberry Pi operating systems.

So in your testing and building, you must test each PR separately, by itself, compiling against the minimum LDC version, using a script similar to the following (assuming you already know how to install 'ldc' manually, and can install v1.20.1):

#!/bin/bash
  
PR=2628

rm -rf ./onedrive-pr${PR}
git clone https://github.com/abraunegg/onedrive.git onedrive-pr${PR}
cd onedrive-pr${PR}
git fetch origin pull/${PR}/head:pr${PR}
git checkout pr${PR}

# MIN LDC Version to compile
# MIN Version for ARM / Compiling with LDC
#source ~/dlang/ldc-1.18.0/activate
source ~/dlang/ldc-1.20.1/activate


./configure --enable-debug --enable-notifications; make clean; make;
deactivate
./onedrive --version

When using this script, against your PR, it generates the following error:

ldc2  -w -g -O -J. -d-debug -gc -L-lcurl -L-lsqlite3  -L-ldl src/main.d src/config.d src/log.d src/util.d src/qxor.d src/curlEngine.d src/onedrive.d src/sync.d src/itemdb.d src/sqlite.d src/clientSideFiltering.d src/monitor.d src/arsd/cgi.d -ofonedrive
onedrive.o:cgi.d:function _D7monitor23MonitorBackgroundWorker11__fieldDtorMFNeZv: error: undefined reference to '_D3std7process4Pipe11__fieldDtorMOFNeZv'
collect2: error: ld returned 1 exit status
Error: /usr/bin/cc failed with status: 1

You must make your code compatible with LDC v1.20.1 at a minimum.

[abraunegg]

@JC-comp
This PR now has conflicts that need to be resolved

[JC-comp]

Update

• Ensure backward compatibility with ldc v1.20.1 and test the compilation
• Resolve conflicts
• Fix shutdown process

[abraunegg]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.